We require contributors to sign our Contributor License Agreement, and we don't have @perfecto25 on file. You can sign our CLA at https://zed.dev/cla. Once you've signed, post a comment here that says '@cla-bot check'.

@cla-bot check

We require contributors to sign our Contributor License Agreement, and we don't have @perfecto25 on file. You can sign our CLA at https://zed.dev/cla. Once you've signed, post a comment here that says '@cla-bot check'.

The cla-bot has been summoned, and re-checked this pull request!

We require contributors to sign our Contributor License Agreement, and we don't have @perfecto25 on file. You can sign our CLA at https://zed.dev/cla. Once you've signed, post a comment here that says '@cla-bot check'.

@cla-bot check

We require contributors to sign our Contributor License Agreement, and we don't have @perfecto25 on file. You can sign our CLA at https://zed.dev/cla. Once you've signed, post a comment here that says '@cla-bot check'.

The cla-bot has been summoned, and re-checked this pull request!

We require contributors to sign our Contributor License Agreement, and we don't have @perfecto25 on file. You can sign our CLA at https://zed.dev/cla. Once you've signed, post a comment here that says '@cla-bot check'.

@cla-bot check

@cla-bot check

The cla-bot has been summoned, and re-checked this pull request!

Hey,

FYI I’ve already submitted a Salt extension 2 weeks ago, see #5136.
Your extension seems to be pretty similar to mine, maybe we should merge them?

Hey,

FYI I’ve already submitted a Salt extension 2 weeks ago, see #5136. Your extension seems to be pretty similar to mine, maybe we should merge them?

nice, i didnt see your PR before I added this

I installed your extension, but Im not seeing syntax highlighting for yaml, only jinja

we should merge these 2 repos into 1, no point of having 2 extensions for same thing, either I can add your extnesion logic into my repo or vice versa, but the yaml syntax should be there also, ie

I haven't been able to reproduce the problem on my side:

I use Zed built-in YAML Tree-sitter grammar so it should works out of the box. Maybe you have conflicting extensions?

I haven't been able to reproduce the problem on my side:

I use Zed built-in YAML Tree-sitter grammar so it should works out of the box. Maybe you have conflicting extensions?

let me try clearing all my ext, probably my env is messed up

strange, i dont have anything besides these ext

yaml syntax not showing

im on fedora 43 Linux mrxmac3 6.18.13-200.fc43.x86_64

zed v 0.228.0

its def using your ext for parsing

I figured it out: your theme colors YAML keys (property) using the same color as text (editor.foreground): #abb2bf. See here.

Colors are defined in themes, not in extensions, as each user can define its own colors. But you can overrides your theme by defining experimental.theme_overrides in settings.json:

  "experimental.theme_overrides": {
    "syntax": {
      "property": {
        "color": "#HEX_CODE",
      },
    },
  },

I figured it out: your theme colors YAML keys (property) using the same color as text (editor.foreground): #abb2bf. See here.

Colors are defined in themes, not in extensions, as each user can define its own colors. But you can overrides your theme by defining experimental.theme_overrides in settings.json:

  "experimental.theme_overrides": {
    "syntax": {
      "property": {
        "color": "#HEX_CODE",
      },
    },
  },

can confirm its the onedark theme, i removed it and its showing this

for some reason YAML color is breaking here

im down to only 4 ext

Fixed, that was an issue in tree-sitter-jinja.
Just do a git pull and rebuild the extension in Zed.

Fixed, that was an issue in tree-sitter-jinja. Just do a git pull and rebuild the extension in Zed.

yeah looks good now, Im gonna close this PR and delete my branch

this is a duplicate extenstion , closing